Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same name for definition and container #96

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

wdconinc
Copy link
Contributor

Rationale: instill the notion that definitions and containers should have consistent names, differing only in extension.

Rationale: instill the notion that definitions and containers should have consistent names, differing only in extension.
@welcome
Copy link

welcome bot commented Jan 10, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@wdconinc wdconinc requested review from michmx and mambelli January 10, 2023 20:10
@michmx
Copy link
Member

michmx commented Jan 10, 2023

Thanks, @wdconinc ! Agree with the change.

@wdconinc wdconinc merged commit a1f5fa4 into gh-pages Jan 10, 2023
@wdconinc wdconinc deleted the 05-definition-container-same-name branch January 10, 2023 21:24
@welcome
Copy link

welcome bot commented Jan 10, 2023

Congrats on merging your first pull request 🎉! We greatly appreciate it.
You might be eligible to be added to the HSF Training Community page (see the instructions on the page for how to create a profile). If you already have created a profile previously, make sure you're also added to the current year. If this repository features a list of contributors at the bottom of the readme, you might also be eligible to add yourself there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants